Skip to content

feat(giga): use giga executor with OCC by default#3521

Merged
masih merged 3 commits into
mainfrom
asr/giga-default
Jun 10, 2026
Merged

feat(giga): use giga executor with OCC by default#3521
masih merged 3 commits into
mainfrom
asr/giga-default

Conversation

@arajasek

Copy link
Copy Markdown
Contributor

Describe your changes and provide context

This PR makes the giga executor, with OCC enabled, the default behaviour. This means that:

  • when a new config TOML is generated, it will have these fields set to true
  • when these fields are absent (eg. old config files), the behaviour will default to true

The only nodes not running Giga after this change will be those with these 2 fields explicitly set to false.

Testing performed to validate your change

@cursor

cursor Bot commented May 29, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Default-on parallel EVM execution changes production behavior for nodes without explicit opt-out; blocktest isolation limits test impact.

Overview
Turns on the Giga executor and OCC by default for nodes: DefaultConfig now sets both enabled and occ_enabled to true, and the generated TOML template comments reflect those defaults. Config keys that are missing (older files) therefore resolve to Giga + OCC unless explicitly set to false.

The blocktest CLI overrides Viper to disable Giga and OCC before building the app, so Ethereum Foundation block tests keep using the standard EvmKeeper / reference EVM path instead of the parallel Giga engine (which would not match how those tests assert state).

Reviewed by Cursor Bugbot for commit 238dbf8. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 10, 2026, 2:48 PM

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.18%. Comparing base (3c0c729) to head (238dbf8).

Files with missing lines Patch % Lines
cmd/seid/cmd/blocktest.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
- Coverage   59.18%   58.18%   -1.01%     
==========================================
  Files        2210     2139      -71     
  Lines      183250   173506    -9744     
==========================================
- Hits       108455   100949    -7506     
+ Misses      65003    63565    -1438     
+ Partials     9792     8992     -800     
Flag Coverage Δ
sei-chain-pr 23.65% <0.00%> (?)
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
giga/executor/config/config.go 60.00% <ø> (ø)
cmd/seid/cmd/blocktest.go 0.00% <0.00%> (ø)

... and 244 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek force-pushed the asr/giga-default branch from dd6aa84 to fbb57f1 Compare June 1, 2026 13:42
@arajasek arajasek force-pushed the asr/giga-default branch from fbb57f1 to 68825a2 Compare June 1, 2026 17:58
@arajasek arajasek added this pull request to the merge queue Jun 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 10, 2026
@masih masih enabled auto-merge June 10, 2026 14:47
@masih masih added this pull request to the merge queue Jun 10, 2026
Merged via the queue into main with commit 9833853 Jun 10, 2026
55 checks passed
@masih masih deleted the asr/giga-default branch June 10, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants